Summary: | [Chromium] Call mimeRegistry directly | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||||
Component: | WebKit Misc. | Assignee: | Mark Pilgrim (Google) <pilgrim> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, fishd, haraken, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 82948 | ||||||||
Attachments: |
|
Description
Mark Pilgrim (Google)
2012-04-19 06:46:11 PDT
Created attachment 137895 [details]
Patch
Comment on attachment 137895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137895&action=review > Source/WebCore/platform/chromium/MIMETypeRegistryChromium.cpp:68 > - String ext = PlatformSupport::preferredExtensionForMIMEType(type); > + String ext = WebKit::Platform::current()->mimeRegistry()->mimeTypeFromFile(type); This is wrong? Created attachment 137904 [details]
Patch
(In reply to comment #2) > (From update of attachment 137895 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137895&action=review > > > Source/WebCore/platform/chromium/MIMETypeRegistryChromium.cpp:68 > > - String ext = PlatformSupport::preferredExtensionForMIMEType(type); > > + String ext = WebKit::Platform::current()->mimeRegistry()->mimeTypeFromFile(type); > > This is wrong? Oops, fixed. Comment on attachment 137904 [details] Patch Clearing flags on attachment: 137904 Committed r114641: <http://trac.webkit.org/changeset/114641> All reviewed patches have been landed. Closing bug. |