Bug 84331

Summary: Web Inspector: introduce styles panel as an experiment
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch vsevik: review+

Description Pavel Feldman 2012-04-19 05:40:46 PDT
This change introduces new "Styles" panel that looks like the "Scripts" one, but operates only stylesheets. This is happening under the experimental flag.
Comment 1 Pavel Feldman 2012-04-19 05:44:04 PDT
Created attachment 137885 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-04-19 08:13:54 PDT
Comment on attachment 137885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137885&action=review

> Source/WebCore/inspector/front-end/StylesPanel.js:51
> +    this._navigatorView = this._navigator.view;

Is this field needed?

> Source/WebCore/inspector/front-end/StylesPanel.js:69
> +

Please remove this line.

> Source/WebCore/inspector/front-end/StylesPanel.js:154
> +        var sourceFrame = this._showFile(uiSourceCode);

_showFile does not return anything. Did you mean:
this._showFile(uiSourceCode);
var sourceFrame = this._sourceFramesForResource.get(uiSourceCode);
Comment 3 Pavel Feldman 2012-04-19 09:20:16 PDT
Committed r114637: <http://trac.webkit.org/changeset/114637>