Bug 84302

Summary:

JSC testing should have complete coverage over typed array types

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	ggaren: review+

Description Filip Pizlo 2012-04-18 16:58:55 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2012-04-18 17:04:18 PDT

Created attachment 137805 [details]
the patch

Comment 2 Geoffrey Garen 2012-04-18 17:12:31 PDT

Comment on attachment 137805 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137805&action=review

r=me, with a comment below:

> LayoutTests/fast/js/script-tests/dfg-uint8array.js:109
> +        shouldBe("safeGetter(a, b, c)", "" + safeGetter(checkA, b, c));

Would be nice to put in the actual values of b and c instead of the letters, so it's clearer what went wrong if something goes wrong.

> LayoutTests/fast/js/script-tests/dfg-uint8array.js:136
> +        shouldBe("getter(a, b, c)", "" + safeGetter(a, b));

Ditto.

Comment 3 Filip Pizlo 2012-04-18 17:16:10 PDT

Landed without Geoff suggestions in: http://trac.webkit.org/changeset/114587

Will land Geoff's suggestions in a separate patch.

Comment 4 Filip Pizlo 2012-04-18 18:12:52 PDT

Landed in http://trac.webkit.org/changeset/114594

Comment 5 Filip Pizlo 2012-04-19 09:24:19 PDT

Landed float64 test support in http://trac.webkit.org/changeset/114639