Bug 84297

Summary:

FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more information about the form being submitted

Product:

WebKit

Reporter:

Jon Honeycutt <jhoneycutt>

Component:

WebCore Misc.

Assignee:

Jon Honeycutt <jhoneycutt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, beidson, g.czajkowski, japhet, rakuco, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Patch v2	buildbot: commit-queue-
Patch v3	buildbot: commit-queue-
Patch v4	aestes: review+

Jon Honeycutt

Reported 2012-04-18 16:06:01 PDT

FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more information about the form being submitted.

Attachments
Patch (24.73 KB, patch) 2012-04-20 23:19 PDT, Jon Honeycutt	buildbot: commit-queue-	Details Formatted Diff Diff
Patch v2 (26.27 KB, patch) 2012-04-24 17:30 PDT, Jon Honeycutt	buildbot: commit-queue-	Details Formatted Diff Diff
Patch v3 (26.82 KB, patch) 2012-04-24 19:50 PDT, Jon Honeycutt	buildbot: commit-queue-	Details Formatted Diff Diff
Patch v4 (27.92 KB, patch) 2012-04-24 20:28 PDT, Jon Honeycutt	aestes: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Jon Honeycutt

Comment 1 2012-04-20 23:19:21 PDT

Created attachment 138222 [details] Patch

Build Bot

Comment 2 2012-04-20 23:43:40 PDT

Comment on attachment 138222 [details] Patch Attachment 138222 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12476386

Jon Honeycutt

Comment 3 2012-04-24 17:30:47 PDT

Created attachment 138700 [details] Patch v2

Build Bot

Comment 4 2012-04-24 18:45:50 PDT

Comment on attachment 138700 [details] Patch v2 Attachment 138700 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12521360

Jon Honeycutt

Comment 5 2012-04-24 19:50:04 PDT

Created attachment 138721 [details] Patch v3

Build Bot

Comment 6 2012-04-24 20:14:01 PDT

Comment on attachment 138721 [details] Patch v3 Attachment 138721 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12523449

Jon Honeycutt

Comment 7 2012-04-24 20:28:36 PDT

Created attachment 138728 [details] Patch v4

Andy Estes

Comment 8 2012-04-30 15:32:53 PDT

Comment on attachment 138728 [details] Patch v4 View in context: https://bugs.webkit.org/attachment.cgi?id=138728&action=review > Source/WebCore/html/HTMLFormElement.h:114 > + void getTextFieldData(StringPairVector& fieldNamesAndValues) const; FormState calls what this function collects 'textFieldValues', which I think is somewhat more descriptive than 'textFieldData'. Perhaps you should call this 'getTextFieldValues'. Also, since the StyleBot wants you to give an argument name here, you should use the same name you used in the function's definition.

Jon Honeycutt

Comment 9 2012-05-02 19:54:35 PDT

(In reply to comment #8) > (From update of attachment 138728 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138728&action=review > > > Source/WebCore/html/HTMLFormElement.h:114 > > + void getTextFieldData(StringPairVector& fieldNamesAndValues) const; > > FormState calls what this function collects 'textFieldValues', which I think is somewhat more descriptive than 'textFieldData'. Perhaps you should call this 'getTextFieldValues'. Also, since the StyleBot wants you to give an argument name here, you should use the same name you used in the function's definition. Landed with this change in <http://trac.webkit.org/changeset/115926>.

Note You need to log in before you can comment on or make changes to this bug.