Bug 84297

Summary: FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more information about the form being submitted
Product: WebKit Reporter: Jon Honeycutt <jhoneycutt>
Component: WebCore Misc.Assignee: Jon Honeycutt <jhoneycutt>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, g.czajkowski, japhet, rakuco, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Patch v2
buildbot: commit-queue-
Patch v3
buildbot: commit-queue-
Patch v4 aestes: review+

Description Jon Honeycutt 2012-04-18 16:06:01 PDT 
FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more information about the form being submitted.
Comment 1 Jon Honeycutt 2012-04-20 23:19:21 PDT 
Created attachment 138222 [details]
Patch
Comment 2 Build Bot 2012-04-20 23:43:40 PDT 
Comment on attachment 138222 [details]
Patch

Attachment 138222 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12476386
Comment 3 Jon Honeycutt 2012-04-24 17:30:47 PDT 
Created attachment 138700 [details]
Patch v2
Comment 4 Build Bot 2012-04-24 18:45:50 PDT 
Comment on attachment 138700 [details]
Patch v2

Attachment 138700 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12521360
Comment 5 Jon Honeycutt 2012-04-24 19:50:04 PDT 
Created attachment 138721 [details]
Patch v3
Comment 6 Build Bot 2012-04-24 20:14:01 PDT 
Comment on attachment 138721 [details]
Patch v3

Attachment 138721 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12523449
Comment 7 Jon Honeycutt 2012-04-24 20:28:36 PDT 
Created attachment 138728 [details]
Patch v4
Comment 8 Andy Estes 2012-04-30 15:32:53 PDT 
Comment on attachment 138728 [details]
Patch v4

View in context: https://bugs.webkit.org/attachment.cgi?id=138728&action=review

> Source/WebCore/html/HTMLFormElement.h:114
> +    void getTextFieldData(StringPairVector& fieldNamesAndValues) const;

FormState calls what this function collects 'textFieldValues', which I think is somewhat more descriptive than 'textFieldData'. Perhaps you should call this 'getTextFieldValues'. Also, since the StyleBot wants you to give an argument name here, you should use the same name you used in the function's definition.
Comment 9 Jon Honeycutt 2012-05-02 19:54:35 PDT 
(In reply to comment #8)
> (From update of attachment 138728 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138728&action=review
> 
> > Source/WebCore/html/HTMLFormElement.h:114
> > +    void getTextFieldData(StringPairVector& fieldNamesAndValues) const;
> 
> FormState calls what this function collects 'textFieldValues', which I think is somewhat more descriptive than 'textFieldData'. Perhaps you should call this 'getTextFieldValues'. Also, since the StyleBot wants you to give an argument name here, you should use the same name you used in the function's definition.

Landed with this change in <http://trac.webkit.org/changeset/115926>.