Bug 84285

Summary: IndexedDB: remove IDB(Index|ObjectStore)BackendImpl::get/getKey for IDBKey
Product: WebKit Reporter: Alec Flett <alecflett>
Component: WebCore Misc.Assignee: Alec Flett <alecflett>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, jsbell, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 83638    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Alec Flett
Reported 2012-04-18 14:54:03 PDT
once bug 83638 is fixed, we'll be able to remove the backend support for get/getKey with just an IDBKey, since everything is now implemented in terms of an IDBKeyRange
Attachments
Patch (16.99 KB, patch)
2012-04-23 14:18 PDT, Alec Flett 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alec Flett
Comment 1 2012-04-23 14:18:26 PDT
Created attachment 138425 [details] Patch
Alec Flett
Comment 2 2012-04-23 14:20:17 PDT
This is purely code removal... ojan@ - r? cq?
WebKit Review Bot
Comment 3 2012-04-23 14:21:31 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Dimitri Glazkov (Google)
Comment 4 2012-04-23 14:28:52 PDT
Comment on attachment 138425 [details] Patch delete code? delicious! Are you sure this won't bomb? :)
WebKit Review Bot
Comment 5 2012-04-23 18:50:24 PDT
Comment on attachment 138425 [details] Patch Clearing flags on attachment: 138425 Committed r114981: <http://trac.webkit.org/changeset/114981>
WebKit Review Bot
Comment 6 2012-04-23 18:50:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.