Bug 84273

Summary: [V8] Pass Isolate to toV8() (Part6)
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84074    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
webkit.review.bot: commit-queue-
patch for landing none

Kentaro Hara
Reported 2012-04-18 13:45:32 PDT
The objective is to pass Isolate to all toV8()s. Since there are a lot of toV8()s, I'll make the change step by step. In this bug, we pass Isolate to toV8() in several custom bindings. I think this will continue to Part7 or so.
Attachments
Patch (19.46 KB, patch)
2012-04-18 13:51 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (23.40 KB, patch)
2012-04-18 13:57 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (26.40 KB, patch)
2012-04-18 14:00 PDT, Kentaro Hara 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
patch for landing (21.48 KB, patch)
2012-04-23 12:59 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-04-18 13:51:19 PDT
Created attachment 137760 [details] Patch
Kentaro Hara
Comment 2 2012-04-18 13:57:22 PDT
Created attachment 137761 [details] Patch
Kentaro Hara
Comment 3 2012-04-18 14:00:39 PDT
Created attachment 137762 [details] Patch
WebKit Review Bot
Comment 4 2012-04-23 11:49:13 PDT
Comment on attachment 137762 [details] Patch Rejecting attachment 137762 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: stom/V8StyleSheetListCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8XSLTProcessorCustom.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Nate Chapin']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12472836
Kentaro Hara
Comment 5 2012-04-23 12:59:29 PDT
Created attachment 138404 [details] patch for landing
WebKit Review Bot
Comment 6 2012-04-23 17:55:14 PDT
Comment on attachment 138404 [details] patch for landing Clearing flags on attachment: 138404 Committed r114972: <http://trac.webkit.org/changeset/114972>
Note You need to log in before you can comment on or make changes to this bug.