Bug 84244

Summary: Web Inspector: extract script navigator overlay logic into the scripts navigator controller.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, haraken, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch vsevik: review+

Pavel Feldman
Reported 2012-04-18 08:15:30 PDT
Overlay logic is well separable from the scripts panel and does not belong there. Extracting it into a separate class.
Attachments
Patch (18.01 KB, patch)
2012-04-18 08:19 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (17.35 KB, patch)
2012-04-18 08:22 PDT, Pavel Feldman 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-04-18 08:19:10 PDT
Created attachment 137694 [details] Patch
WebKit Review Bot
Comment 2 2012-04-18 08:22:29 PDT
Attachment 137694 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/v8/V8IsolatedContext.cpp:44: "stdio.h" already included at Source/WebCore/bindings/v8/V8IsolatedContext.cpp:42 [build/include] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Pavel Feldman
Comment 3 2012-04-18 08:22:38 PDT
Created attachment 137697 [details] Patch
Pavel Feldman
Comment 4 2012-04-18 11:02:14 PDT
Committed r114532: <http://trac.webkit.org/changeset/114532>
Note You need to log in before you can comment on or make changes to this bug.