Bug 84244 - Web Inspector: extract script navigator overlay logic into the scripts navigator controller.
Summary: Web Inspector: extract script navigator overlay logic into the scripts naviga...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2012-04-18 08:15 PDT by Pavel Feldman
Modified: 2012-04-18 11:02 PDT (History)
14 users (show)

See Also:

Patch (18.01 KB, patch)
2012-04-18 08:19 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (17.35 KB, patch)
2012-04-18 08:22 PDT, Pavel Feldman
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-04-18 08:15:30 PDT
Overlay logic is well separable from the scripts panel and does not belong there. Extracting it into a separate class.
Comment 1 Pavel Feldman 2012-04-18 08:19:10 PDT
Created attachment 137694 [details]
Comment 2 WebKit Review Bot 2012-04-18 08:22:29 PDT
Attachment 137694 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/bindings/v8/V8IsolatedContext.cpp:44:  "stdio.h" already included at Source/WebCore/bindings/v8/V8IsolatedContext.cpp:42  [build/include] [4]
Total errors found: 1 in 4 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Pavel Feldman 2012-04-18 08:22:38 PDT
Created attachment 137697 [details]
Comment 4 Pavel Feldman 2012-04-18 11:02:14 PDT
Committed r114532: <http://trac.webkit.org/changeset/114532>