Bug 84243

Summary: Clean-up WheelEvent Conversion
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: WebKit QtAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: menard, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 75006    
Attachments:
Description Flags
Patch none

Allan Sandfeld Jensen
Reported 2012-04-18 08:04:22 PDT
WheelEvent conversion is currently doesnt treat full ticks and partial ticks the same way. This appears to have been done to support wheel-events emitted by DRT. This should be cleaned up so all wheel-events are treated the same, and DRT emits correct events. The problem is in particular to distinguish better between wheel-delta and pixel-delta which are often confused, and happens to be identical on some other platforms.
Attachments
Patch (12.87 KB, patch)
2012-04-18 08:14 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-04-18 08:14:41 PDT
Created attachment 137692 [details] Patch
Simon Hausmann
Comment 2 2012-04-18 11:45:16 PDT
Comment on attachment 137692 [details] Patch r=me. Nice cleanup! There have been some cleanups in QWheelEvent lately, too, FWIW: http://qt.gitorious.org/qt/qtbase/commit/5a2efb490bc3549ef42420a0dafcf22072785e0d
WebKit Review Bot
Comment 3 2012-04-18 12:48:51 PDT
Comment on attachment 137692 [details] Patch Clearing flags on attachment: 137692 Committed r114546: <http://trac.webkit.org/changeset/114546>
WebKit Review Bot
Comment 4 2012-04-18 12:48:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.