Bug 84240

Summary: Web Inspector: DataGrid should use explicit root node
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: alph, apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+

Description Yury Semikhatsky 2012-04-18 07:29:27 PDT 
Instead of pretending to be a regular node DataGrid object should have an explicit root node that would contain all its children. This way we don't need to share some methods between DataGridNode and DataGrid.
Comment 1 Yury Semikhatsky 2012-04-18 07:49:11 PDT 
Created attachment 137686 [details]
Patch
Comment 2 Pavel Feldman 2012-04-18 07:54:05 PDT 
Comment on attachment 137686 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137686&action=review

> Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js:208
> +        this._dataGrid = new WebInspector.DataGrid(columns, new WebInspector.DataGridNode());

You should create root node implicitly within the data grid.
Comment 3 Yury Semikhatsky 2012-04-18 07:57:37 PDT 
(In reply to comment #2)
> (From update of attachment 137686 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137686&action=review
> 
> > Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js:208
> > +        this._dataGrid = new WebInspector.DataGrid(columns, new WebInspector.DataGridNode());
> 
> You should create root node implicitly within the data grid.

Done.
Comment 4 Yury Semikhatsky 2012-04-18 08:00:13 PDT 
Committed r114504: <http://trac.webkit.org/changeset/114504>