Summary: | [CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dominik Röttsches (drott) <d-r> | ||||||
Component: | WebKit EFL | Assignee: | Thiago Marcos P. Santos <tmpsantos> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dbates, gyuyoung.kim, lucas.de.marchi, mxie, naginenis, paroga, rakuco, rwlbuis, tmpsantos, tonikitoo, webkit.review.bot | ||||||
Priority: | P1 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Dominik Röttsches (drott)
2012-04-18 00:26:42 PDT
--cmakearg="-DCMAKE_VERBOSE_MAKEFILE=ON" as an argument to build-webkit --efl might be helpful. Looks like EFl buildbots are triggering rebuilds of changes only when we force a clean build. The root cause of this issue is ONLY_BUILD_JAVASCRIPTCORE is always ON after running run-javascriptcore-tests(value is stored in CMakeCache.txt) and the following check in CMakeLists.txt ignores building other modules when this option is ON. OPTION(ONLY_BUILD_JAVASCRIPTCORE "only build JavaScriptCore") IF (ONLY_BUILD_JAVASCRIPTCORE) SET(ENABLE_WEBCORE OFF) SET(ENABLE_WEBKIT OFF) SET(ENABLE_WEBKIT2 OFF) SET(ENABLE_TOOLS OFF) ENDIF () To fix the issue we should set this option OFF when we run build-webkit. Created attachment 137674 [details]
Patch fixing buildsystem.
Created attachment 137677 [details]
Same patch, better changelog.
Comment on attachment 137677 [details] Same patch, better changelog. View in context: https://bugs.webkit.org/attachment.cgi?id=137677&action=review > Tools/Scripts/build-jsc:73 > + buildCMakeProjectOrExit(0, cmakeBasedPortName(), undef, "jsc", cmakeBasedPortArguments()); # This call only returns if nothing wrong happened As we were discussing on IRC, this will break if JSC_EXECUTABLE_NAME is set to something else in Options${PORT}.cmake. Adding a note in a comment before this line should be enough for now, I guess. Comment on attachment 137677 [details] Same patch, better changelog. View in context: https://bugs.webkit.org/attachment.cgi?id=137677&action=review >> Tools/Scripts/build-jsc:73 >> + buildCMakeProjectOrExit(0, cmakeBasedPortName(), undef, "jsc", cmakeBasedPortArguments()); # This call only returns if nothing wrong happened > > As we were discussing on IRC, this will break if JSC_EXECUTABLE_NAME is set to something else in Options${PORT}.cmake. Adding a note in a comment before this line should be enough for now, I guess. Why not use JSC_EXECUTABLE_NAME in the first place instead of hardcoding jsc? Comment on attachment 137677 [details]
Same patch, better changelog.
Looks good.
Comment on attachment 137677 [details] Same patch, better changelog. Clearing flags on attachment: 137677 Committed r114508: <http://trac.webkit.org/changeset/114508> All reviewed patches have been landed. Closing bug. |