Bug 84224

Summary: JavaScriptCore.gypi not current
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Don Olmstead
Reported 2012-04-17 19:09:06 PDT
The GYPI file containing the source files needed to build JavaScriptCore is not up to date with the latest sources. Actual: A number of source files are not present in JavaScriptCore.gypi Expected: JavaScriptCore.gypi should list all the associated files to build JavaScriptCore
Attachments
Patch (29.97 KB, patch)
2012-04-18 12:34 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (29.82 KB, patch)
2012-04-18 12:54 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2012-04-18 12:34:22 PDT
Created attachment 137739 [details] Patch
Don Olmstead
Comment 2 2012-04-18 12:54:41 PDT
Created attachment 137743 [details] Patch
Eric Seidel (no email)
Comment 3 2012-04-18 13:00:39 PDT
Comment on attachment 137743 [details] Patch LGTM.
WebKit Review Bot
Comment 4 2012-04-18 14:46:14 PDT
Comment on attachment 137743 [details] Patch Clearing flags on attachment: 137743 Committed r114565: <http://trac.webkit.org/changeset/114565>
WebKit Review Bot
Comment 5 2012-04-18 14:46:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.