Bug 84224 - JavaScriptCore.gypi not current
: JavaScriptCore.gypi not current
Status: RESOLVED FIXED
: WebKit
JavaScriptCore
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-04-17 19:09 PST by
Modified: 2012-04-18 14:46 PST (History)


Attachments
Patch (29.97 KB, patch)
2012-04-18 12:34 PST, Don Olmstead
no flags Review Patch | Details | Formatted Diff | Diff
Patch (29.82 KB, patch)
2012-04-18 12:54 PST, Don Olmstead
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-17 19:09:06 PST
The GYPI file containing the source files needed to build JavaScriptCore is not up to date with the latest sources.

Actual:
A number of source files are not present in JavaScriptCore.gypi
Expected:
JavaScriptCore.gypi should list all the associated files to build JavaScriptCore
------- Comment #1 From 2012-04-18 12:34:22 PST -------
Created an attachment (id=137739) [details]
Patch
------- Comment #2 From 2012-04-18 12:54:41 PST -------
Created an attachment (id=137743) [details]
Patch
------- Comment #3 From 2012-04-18 13:00:39 PST -------
(From update of attachment 137743 [details])
LGTM.
------- Comment #4 From 2012-04-18 14:46:14 PST -------
(From update of attachment 137743 [details])
Clearing flags on attachment: 137743

Committed r114565: <http://trac.webkit.org/changeset/114565>
------- Comment #5 From 2012-04-18 14:46:22 PST -------
All reviewed patches have been landed.  Closing bug.