Bug 84224 - JavaScriptCore.gypi not current
: JavaScriptCore.gypi not current
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-17 19:09 PDT by Don Olmstead
Modified: 2012-04-18 14:46 PDT (History)
1 user (show)

See Also:


Attachments
Patch (29.97 KB, patch)
2012-04-18 12:34 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff
Patch (29.82 KB, patch)
2012-04-18 12:54 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2012-04-17 19:09:06 PDT
The GYPI file containing the source files needed to build JavaScriptCore is not up to date with the latest sources.

Actual:
A number of source files are not present in JavaScriptCore.gypi
Expected:
JavaScriptCore.gypi should list all the associated files to build JavaScriptCore
Comment 1 Don Olmstead 2012-04-18 12:34:22 PDT
Created attachment 137739 [details]
Patch
Comment 2 Don Olmstead 2012-04-18 12:54:41 PDT
Created attachment 137743 [details]
Patch
Comment 3 Eric Seidel 2012-04-18 13:00:39 PDT
Comment on attachment 137743 [details]
Patch

LGTM.
Comment 4 WebKit Review Bot 2012-04-18 14:46:14 PDT
Comment on attachment 137743 [details]
Patch

Clearing flags on attachment: 137743

Committed r114565: <http://trac.webkit.org/changeset/114565>
Comment 5 WebKit Review Bot 2012-04-18 14:46:22 PDT
All reviewed patches have been landed.  Closing bug.