Bug 84215

Summary: [Chromium] Solid color shader should use premultiplied alpha.
Product: WebKit Reporter: David Reveman <reveman>
Component: WebCore Misc.Assignee: David Reveman <reveman>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, jamesr, piman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84197    
Attachments:
Description Flags
Patch none

David Reveman
Reported 2012-04-17 17:14:22 PDT
This is mostly for consistency. Textures are expected to have premultiplied alpha so I don't think there's a good reason not to expect that in the solid color shader as well. Also faster not to compute the color per-pixel even though I doubt that matters.
Attachments
Patch (3.56 KB, patch)
2012-04-17 17:48 PDT, David Reveman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Reveman
Comment 1 2012-04-17 17:48:22 PDT
Created attachment 137642 [details] Patch
Antoine Labour
Comment 2 2012-04-17 17:52:01 PDT
LGTM
Adrienne Walker
Comment 3 2012-04-18 11:23:42 PDT
Comment on attachment 137642 [details] Patch Sounds good. R=me.
WebKit Review Bot
Comment 4 2012-04-18 13:35:00 PDT
Comment on attachment 137642 [details] Patch Clearing flags on attachment: 137642 Committed r114552: <http://trac.webkit.org/changeset/114552>
WebKit Review Bot
Comment 5 2012-04-18 13:35:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.