Bug 84194

Summary: REGRESSION(r112155): Children style not always recalculated in CSS animations
Product: WebKit Reporter: Loïc Yhuel <loic.yhuel>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, igor.oliveira, marc.hoyois, robarnold, simon.fraser
Priority: P1 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
blinking text animation none

Loïc Yhuel
Reported 2012-04-17 14:34:45 PDT
Created attachment 137607 [details] blinking text animation The attached blink animation no longer works since https://bugs.webkit.org/show_bug.cgi?id=79389 has landed. There are paints, but the text is always black. In Element::recalcStyle, when the text color should be changed to white : - styleChangeType() is SyntheticStyleChange, the animated style (color: white) is set on the Element in setRenderStyle(newStyle) - currentStyle and newStyle are the same (color: black), so ch is NoChange - After r112155, change is no more set to Force, so Text::recalcTextStyle is called with NoChange as argument, the style of the text is not changed, so the text color remains black.
Attachments
blinking text animation (423 bytes, text/html)
2012-04-17 14:34 PDT, Loïc Yhuel 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-04-17 14:49:08 PDT
<rdar://problem/11267408>
Alexey Proskuryakov
Comment 2 2012-05-22 10:55:51 PDT
Rob, would you be willing to investigate this regression?
Rob Arnold
Comment 3 2012-05-22 18:32:53 PDT
Yes, I should have investigated sooner. Unfortunately it'll probably be 2 weeks before I can really dig into this (vacation + needing to unblock a bunch of people at FB). It looks like Loïc did some nice investigation; my current plan is to see if forcing recalcuation when the new style has inheritable properties (ideally if they changed / are used) will work.
Dean Jackson
Comment 4 2012-05-25 12:34:37 PDT
We're getting multiple reports of this breaking various things. I'm going to revert the change from https://bugs.webkit.org/show_bug.cgi?id=79389
Dean Jackson
Comment 5 2012-05-25 13:03:48 PDT
Reverted in http://trac.webkit.org/changeset/118553
Dean Jackson
Comment 6 2012-05-25 13:08:41 PDT
Reverting fixed the attached testcase.
Marc Hoyois
Comment 7 2012-06-07 21:38:51 PDT
*** Bug 84371 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.