Bug 84190

Summary:

nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

New Bugs

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, ojan, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ojan: review+

Description Dirk Pranke 2012-04-17 13:49:43 PDT

nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port

Comment 1 Dirk Pranke 2012-04-17 13:50:03 PDT

Created attachment 137598 [details]
Patch

Comment 2 Ojan Vafai 2012-04-17 14:25:41 PDT

Comment on attachment 137598 [details]
Patch

Would be nice if the changelog had a description of when you'd get an IOError.

Comment 3 Dirk Pranke 2012-04-17 14:28:20 PDT

(In reply to comment #2)
> (From update of attachment 137598 [details])
> Would be nice if the changelog had a description of when you'd get an IOError.

Oh, you get the IOError when the layout test helper has exited early (due to the ctrl-c) and we try to write to it. I will make that clearer.

Comment 4 Dirk Pranke 2012-04-17 15:09:42 PDT

Committed r114442: <http://trac.webkit.org/changeset/114442>