Bug 84166

Summary: Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: aa, abarth, dglazkov, haraken, japhet, vsevik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 84253    
Bug Blocks:    
Attachments:
Description Flags
Patch
yurys: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-02 none

Pavel Feldman
Reported 2012-04-17 10:53:32 PDT
V8IsolatedContext is getting debug id assigned post-construction. At the same time, it gets all helper module scripts injected within the constructor. As a result, scripts end up in the main world's list.
Attachments
Patch (5.74 KB, patch)
2012-04-17 11:01 PDT, Pavel Feldman 		yurys: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-02 (5.92 MB, application/zip)
2012-04-17 11:58 PDT, WebKit Review Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-04-17 11:01:14 PDT
Created attachment 137562 [details] Patch
WebKit Review Bot
Comment 2 2012-04-17 11:58:22 PDT
Comment on attachment 137562 [details] Patch Attachment 137562 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12418777 New failing tests: svg/transforms/text-with-pattern-with-svg-transform.svg
WebKit Review Bot
Comment 3 2012-04-17 11:58:28 PDT
Created attachment 137571 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Pavel Feldman
Comment 4 2012-04-18 03:10:11 PDT
Committed r114497: <http://trac.webkit.org/changeset/114497>
Pavel Feldman
Comment 5 2012-04-18 11:15:15 PDT
Committed r114535: <http://trac.webkit.org/changeset/114535>
Note You need to log in before you can comment on or make changes to this bug.