|Summary:||Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot|
|Product:||WebKit||Reporter:||Ryosuke Niwa <firstname.lastname@example.org>|
|Component:||Tools / Tests||Assignee:||Ryosuke Niwa <email@example.com>|
|Severity:||Normal||CC:||firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org|
|Version:||528+ (Nightly build)|
Chromium Win Perf fails to create WebKitBuild directory because mkdir on Windows doesn't support -p option. Since the download step automatically creates WebKitBuild directory now, this step is completely redundant.
Created an attachment (id=137394) [details] Fixes the failure
(From update of attachment 137394 [details]) I assume this step was only used by the perf bot.
You are aware we have unit tests for master.cfg, rght?
(In reply to comment #2) > (From update of attachment 137394 [details] [details]) > I assume this step was only used by the perf bot. It's also used by testers but it's redundant there as well since download-built-product makes WebKitBuild directory as I explained in the change log. (In reply to comment #3) > You are aware we have unit tests for master.cfg, rght? Oh, I didn't know that. Did someone add it recently? I don't think a unit test is helpful for this file though.
I added it long ago. :) It's of some use. it doesn't cover everything by far.
(In reply to comment #5) > I added it long ago. :) It's of some use. it doesn't cover everything by far. I guess we can test whether config.json loads, etc... but we can't really test whether the code change we made is correct or not by unit tests there because most of master.cfg just calls out to other scripts.