Bug 84068

Summary: Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
Product: WebKit Reporter: Ryosuke Niwa <rniwa@webkit.org>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa@webkit.org>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth@webkit.org, eric@webkit.org, lforschler@apple.com, tony@chromium.org, wsiegrist@apple.com
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the failure eric: review+

Description From 2012-04-16 13:27:31 PST
Chromium Win Perf fails to create WebKitBuild directory because mkdir on Windows doesn't support -p option. Since the download step automatically creates WebKitBuild directory now, this step is completely redundant.
------- Comment #1 From 2012-04-16 13:40:36 PST -------
Created an attachment (id=137394) [details]
Fixes the failure
------- Comment #2 From 2012-04-16 13:50:51 PST -------
(From update of attachment 137394 [details])
I assume this step was only used by the perf bot.
------- Comment #3 From 2012-04-16 13:51:12 PST -------
You are aware we have unit tests for master.cfg, rght?
------- Comment #4 From 2012-04-16 13:59:52 PST -------
(In reply to comment #2)
> (From update of attachment 137394 [details] [details])
> I assume this step was only used by the perf bot.

It's also used by testers but it's redundant there as well since download-built-product makes WebKitBuild directory as I explained in the change log.

(In reply to comment #3)
> You are aware we have unit tests for master.cfg, rght?

Oh, I didn't know that. Did someone add it recently? I don't think a unit test is helpful for this file though.
------- Comment #5 From 2012-04-16 14:03:40 PST -------
I added it long ago. :)  It's of some use.  it doesn't cover everything by far.
------- Comment #6 From 2012-04-16 14:14:10 PST -------
(In reply to comment #5)
> I added it long ago. :)  It's of some use.  it doesn't cover everything by far.

I guess we can test whether config.json loads, etc... but we can't really test whether the code change we made is correct or not by unit tests there because most of master.cfg just calls out to other scripts.
------- Comment #7 From 2012-04-17 00:18:49 PST -------
Committed r114353: <http://trac.webkit.org/changeset/114353>