|Summary:||Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot|
|Product:||WebKit||Reporter:||Ryosuke Niwa <rniwa>|
|Component:||Tools / Tests||Assignee:||Ryosuke Niwa <rniwa>|
|Severity:||Normal||CC:||abarth, eric, lforschler, tony, wsiegrist|
|Version:||528+ (Nightly build)|
Description Ryosuke Niwa 2012-04-16 13:27:31 PDT
Chromium Win Perf fails to create WebKitBuild directory because mkdir on Windows doesn't support -p option. Since the download step automatically creates WebKitBuild directory now, this step is completely redundant.
Comment 1 Ryosuke Niwa 2012-04-16 13:40:36 PDT
Created attachment 137394 [details] Fixes the failure
Comment 2 Eric Seidel 2012-04-16 13:50:51 PDT
Comment on attachment 137394 [details] Fixes the failure I assume this step was only used by the perf bot.
Comment 3 Eric Seidel 2012-04-16 13:51:12 PDT
You are aware we have unit tests for master.cfg, rght?
Comment 4 Ryosuke Niwa 2012-04-16 13:59:52 PDT
(In reply to comment #2) > (From update of attachment 137394 [details]) > I assume this step was only used by the perf bot. It's also used by testers but it's redundant there as well since download-built-product makes WebKitBuild directory as I explained in the change log. (In reply to comment #3) > You are aware we have unit tests for master.cfg, rght? Oh, I didn't know that. Did someone add it recently? I don't think a unit test is helpful for this file though.
Comment 5 Eric Seidel 2012-04-16 14:03:40 PDT
I added it long ago. :) It's of some use. it doesn't cover everything by far.
Comment 6 Ryosuke Niwa 2012-04-16 14:14:10 PDT
(In reply to comment #5) > I added it long ago. :) It's of some use. it doesn't cover everything by far. I guess we can test whether config.json loads, etc... but we can't really test whether the code change we made is correct or not by unit tests there because most of master.cfg just calls out to other scripts.