Bug 84053

Summary:

[chromium] Allow WebGestureEvent to store four floating point values

Product:

WebKit

Reporter:

Terry Anderson <tdanderson>

Component:

Platform

Assignee:

Terry Anderson <tdanderson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, fishd, jamesr, rjkroege, tkent+wkapi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

83947

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none

Description Terry Anderson 2012-04-16 10:59:17 PDT

A first step to implementing master bug https://bugs.webkit.org/show_bug.cgi?id=83947. Currently a WebGestureEvent stores two floats (deltaX and deltaY) which are unused in Tap and Press events. This patch will add gammaX and gammaY members to WebGestureEvent so that (deltaX, deltaY) and (gammaX, gammaY) can be used to represent the top left and bottom right coordinates of the enclosing rectangle of the ellipse information associated with the touch event.

Comment 1 Terry Anderson 2012-04-16 12:38:03 PDT

Created attachment 137382 [details]
Patch

Comment 2 WebKit Review Bot 2012-04-16 12:43:26 PDT

Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

Comment 3 WebKit Review Bot 2012-04-16 12:43:55 PDT

Attachment 137382 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Darin Fisher (:fishd, Google) 2012-04-16 12:48:10 PDT

Comment on attachment 137382 [details]
Patch

CQ- due to style error

Comment 5 Terry Anderson 2012-04-16 13:27:04 PDT

Created attachment 137390 [details]
Patch

Comment 6 Terry Anderson 2012-04-16 13:36:06 PDT

Created attachment 137393 [details]
Patch for landing

Comment 7 WebKit Review Bot 2012-04-16 14:51:03 PDT

Comment on attachment 137393 [details]
Patch for landing

Clearing flags on attachment: 137393

Committed r114301: <http://trac.webkit.org/changeset/114301>

Comment 8 WebKit Review Bot 2012-04-16 14:51:11 PDT

All reviewed patches have been landed.  Closing bug.