Bug 84053

Summary: [chromium] Allow WebGestureEvent to store four floating point values
Product: WebKit Reporter: Terry Anderson <tdanderson>
Component: PlatformAssignee: Terry Anderson <tdanderson>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, rjkroege, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 83947    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Terry Anderson
Reported 2012-04-16 10:59:17 PDT
A first step to implementing master bug https://bugs.webkit.org/show_bug.cgi?id=83947. Currently a WebGestureEvent stores two floats (deltaX and deltaY) which are unused in Tap and Press events. This patch will add gammaX and gammaY members to WebGestureEvent so that (deltaX, deltaY) and (gammaX, gammaY) can be used to represent the top left and bottom right coordinates of the enclosing rectangle of the ellipse information associated with the touch event.
Attachments
Patch (6.68 KB, patch)
2012-04-16 12:38 PDT, Terry Anderson 		no flags
DetailsFormatted DiffDiff
Patch (6.65 KB, patch)
2012-04-16 13:27 PDT, Terry Anderson 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.65 KB, patch)
2012-04-16 13:36 PDT, Terry Anderson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Terry Anderson
Comment 1 2012-04-16 12:38:03 PDT
Created attachment 137382 [details] Patch
WebKit Review Bot
Comment 2 2012-04-16 12:43:26 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 3 2012-04-16 12:43:55 PDT
Attachment 137382 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Fisher (:fishd, Google)
Comment 4 2012-04-16 12:48:10 PDT
Comment on attachment 137382 [details] Patch CQ- due to style error
Terry Anderson
Comment 5 2012-04-16 13:27:04 PDT
Created attachment 137390 [details] Patch
Terry Anderson
Comment 6 2012-04-16 13:36:06 PDT
Created attachment 137393 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-04-16 14:51:03 PDT
Comment on attachment 137393 [details] Patch for landing Clearing flags on attachment: 137393 Committed r114301: <http://trac.webkit.org/changeset/114301>
WebKit Review Bot
Comment 8 2012-04-16 14:51:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.