Bug 84046

Summary: Fix WebKit style violations in Source/Webkit/chromium/public/WebMediaPlayer.h
Product: WebKit Reporter: Aaron Colwell <acolwell>
Component: MediaAssignee: Aaron Colwell <acolwell>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Aaron Colwell 2012-04-16 09:48:39 PDT
WebMediaPlayer.h has several style violations that need fixing:
- enum values should be prefixed with the enum name. (Preload::None  -> Preload::PreloadNone)
- WebTimeRange & WebTimeRanges should be in WebTimeRange.h .
Comment 2 Aaron Colwell 2012-04-16 15:13:40 PDT
Created attachment 137412 [details]
Patch
Comment 3 WebKit Review Bot 2012-04-16 15:17:57 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 James Robinson 2012-04-16 15:19:36 PDT
This changes the exposed API, so is there a corresponding chromium patch to update to the new names/etc?
Comment 5 Aaron Colwell 2012-04-16 15:32:23 PDT
(In reply to comment #4)
> This changes the exposed API, so is there a corresponding chromium patch to update to the new names/etc?

There will be. I haven't created it yet. I was planning on landing this, WebKit DEPS roll, landing chromium changes to use new enum name, WebKit chromium deps roll. Remove old names.
Comment 6 James Robinson 2012-04-16 15:53:48 PDT
When this rolls into the chromium tree, will the chromium code using this still compile?
Comment 7 Aaron Colwell 2012-04-16 16:49:40 PDT
(In reply to comment #6)
> When this rolls into the chromium tree, will the chromium code using this still compile?

Yes. I'm building this patch w/ ToT chrome right now. That is why I still have the old enum values in there. The plan is to land this, update chrome to the new enum value names, and then remove to old names in webkit.
Comment 8 James Robinson 2012-04-16 16:53:53 PDT
Ah gotcha, I missed that you were leaving the old values in as aliases.  Proceed!
Comment 9 Aaron Colwell 2012-04-16 16:56:58 PDT
(In reply to comment #8)
> Ah gotcha, I missed that you were leaving the old values in as aliases.  Proceed!

No problem. Could you please cq+ my patch.
Comment 10 WebKit Review Bot 2012-04-16 17:48:38 PDT
Comment on attachment 137412 [details]
Patch

Clearing flags on attachment: 137412

Committed r114329: <http://trac.webkit.org/changeset/114329>
Comment 11 WebKit Review Bot 2012-04-16 17:48:45 PDT
All reviewed patches have been landed.  Closing bug.