Bug 84033

Summary:

[chromium] Enabled threaded animations in DRT

Product:

WebKit

Reporter:

vollick

Component:

WebKit Misc.

Assignee:

vollick

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

abarth, cc-bugs, dglazkov, eric, fishd, jamesr, nduca, tkent, tkent+wkapi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

86013, 90000

Bug Blocks:

83283, 85813

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ec2-cr-linux-04	none
Patch	abarth: review-

vollick

Reported 2012-04-16 06:52:23 PDT

Turn on threaded animations in DumpRenderTree.

Attachments
Patch (5.52 KB, patch) 2012-05-28 08:16 PDT, vollick	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-04 (589.18 KB, application/zip) 2012-05-28 18:42 PDT, WebKit Review Bot	no flags	Details
Patch (24.32 KB, patch) 2012-08-02 06:13 PDT, vollick	abarth: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

vollick

Comment 1 2012-05-28 08:16:38 PDT

Created attachment 144367 [details] Patch

WebKit Review Bot

Comment 2 2012-05-28 18:42:45 PDT

Comment on attachment 144367 [details] Patch Attachment 144367 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12841406 New failing tests: animations/animation-iteration-event-destroy-renderer.html compositing/reflections/nested-reflection-animated.html

WebKit Review Bot

Comment 3 2012-05-28 18:42:48 PDT

Created attachment 144421 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Adrienne Walker

Comment 4 2012-07-18 15:01:27 PDT

Comment on attachment 144367 [details] Patch Removing review flag until DRT tests are passing, if you still want this two month old patch landed.

vollick

Comment 5 2012-08-02 06:13:54 PDT

Created attachment 156060 [details] Patch

WebKit Review Bot

Comment 6 2012-08-02 06:16:31 PDT

Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

Adam Barth

Comment 7 2012-08-02 13:42:04 PDT

Comment on attachment 156060 [details] Patch This patch is spinning in the cr-linux-ews.

Eric Seidel (no email)

Comment 8 2012-08-02 14:04:42 PDT

That happens most often because your patch introduces flakiness. If you click on the cr-linux bubble and examine the individual runs, you'll see flaky results.

Stephen Chenney

Comment 9 2013-04-09 17:05:56 PDT

Marked LayoutTest bugs, bugs with Chromium IDs, and some others as WontFix. Test failure bugs still are trackable via TestExpectations or disabled unit tests.

Note You need to log in before you can comment on or make changes to this bug.