Summary: | [chromium] Layout Test editing/pasteboard/emacs-ctrl-k-with-move.html is failing (CRASH) | ||
---|---|---|---|
Product: | WebKit | Reporter: | Takashi Toyoshima <toyoshim> |
Component: | Tools / Tests | Assignee: | Takashi Toyoshima <toyoshim> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | jiapu.mail, morrita, rniwa |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Takashi Toyoshima
2012-04-16 05:23:53 PDT
update expectations. http://trac.webkit.org/changeset/114248 (In reply to comment #1) > update expectations. > http://trac.webkit.org/changeset/114248 You must not skip this test on Mac. It tests a feature for Mac. You need to resolve the failure. Clearly http://trac.webkit.org/changeset/114220/ is the trigger. Don't hesitate to roll it out. (In reply to comment #3) > Clearly http://trac.webkit.org/changeset/114220/ is the trigger. Don't hesitate to roll it out. If this failure is caused a crash in Editor::insertTextWithoutSendingTextEvent, which seems to be the case to em, the patch in bug 84010 fixes it. Can someone review it? Oops, I miss reverting. Now it's difficult to revert related change 114220, 114231, and 114266. Jia Pu, Could you fix this crush or manually revert them? (In reply to comment #5) > Oops, I miss reverting. > Now it's difficult to revert related change 114220, 114231, and 114266. > > Jia Pu, > Could you fix this crush or manually revert them? It seems http://trac.webkit.org/changeset/114311 has already fixed this. You can revert the test back to original now. Thanks Jia! I revert my previous expectation update. http://trac.webkit.org/changeset/114479 |