| Summary: | DFG should have constant propagation | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | rakuco, webkit.review.bot | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | All | ||||||||||||||||
| OS: | All | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Filip Pizlo
2012-04-15 18:30:35 PDT
Created attachment 137262 [details]
work in progress
Created attachment 137270 [details]
work in progress
Created attachment 137649 [details]
the patch
I think it works
Comment on attachment 137649 [details] the patch Attachment 137649 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12426110 Comment on attachment 137649 [details] the patch Attachment 137649 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12423620 Created attachment 137651 [details]
the patch
Found and fixed a few bugs.
Also added build foo for the non-Mac ports.
Created attachment 137652 [details]
the patch
accidentally messed up GNUmakefile.list.am. fix in this one.
Created attachment 137658 [details]
the patch
Fixed two hilarious bugs that this patch introduced:
- LogicalNot(foo) is not an integer. Really, it isn't. In fact, it's a boolean. Imagine that.
- Don't replace JSConstant or WeakJSConstant with JSConstant, because at best that's a waste of CPU cycles and at worst, it's just plain wrong (WeakJSConstant should not be coerced into a JSConstant).
Landed in http://trac.webkit.org/changeset/114554 Merged in http://trac.webkit.org/changeset/117636 |