Bug 83982

Summary: Update GraphicsContext3DOpenGLES.cpp and fix some issues to build with GLES.
Product: WebKit Reporter: ChangSeok Oh <kevin.cs.oh>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

ChangSeok Oh
Reported 2012-04-14 11:24:37 PDT
There are some issues to build with GLES for WebGL. This bug is for fixing them. 1. GL_BGRA is not defined in OpenGL ES, so it causes build-break at GraphicsContext3D::readRenderingResults. 2. getExtensions() is used without including a proper header file. 3. m_attributes is not defined, it should be replaced with m_attrs. 4. Omitted '}' for namespace WebCore. 5. Function argument of GraphicsContext3D::resolveMultisamplingIfNecessary is mismatched with its declaration.
Attachments
Patch (7.62 KB, patch)
2012-04-14 11:43 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Patch (7.62 KB, patch)
2012-04-14 11:48 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2012-04-14 11:43:58 PDT
Created attachment 137215 [details] Patch
ChangSeok Oh
Comment 2 2012-04-14 11:48:01 PDT
Created attachment 137216 [details] Patch
WebKit Review Bot
Comment 3 2012-04-16 10:06:31 PDT
Comment on attachment 137216 [details] Patch Clearing flags on attachment: 137216 Committed r114268: <http://trac.webkit.org/changeset/114268>
WebKit Review Bot
Comment 4 2012-04-16 10:06:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.