Summary: | Fix pixelSnapping for CalendarPicker, MediaControl and ScrollbarPart | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||
Component: | Layout and Rendering | Assignee: | Emil A Eklund <eae> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, eric.carlson, eric, feature-media-reviews, jchaffraix, leviw, morrita, simon.fraser, tkent, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 60318 | ||||||||
Attachments: |
|
Description
Emil A Eklund
2012-04-13 12:17:15 PDT
Created attachment 137124 [details]
Patch
Comment on attachment 137124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137124&action=review > Source/WebCore/ChangeLog:22 > + * rendering/RenderWidget.cpp: > + (WebCore::RenderWidget::updateWidgetGeometry): Mhhh, left-over from another change? (RenderWidget is not marked in the bug description and should if you are also planning to change it) > Source/WebCore/rendering/RenderWidget.cpp:183 > - LayoutRect contentBox = contentBoxRect(); > + IntRect contentBox = pixelSnappedIntRect(contentBoxRect()); > if (!m_widget->transformsAffectFrameRect()) > return setWidgetGeometry(absoluteContentBox()); > > - LayoutRect absoluteContentBox(localToAbsoluteQuad(FloatQuad(contentBox)).boundingBox()); > + IntRect absoluteContentBox(localToAbsoluteQuad(FloatQuad(contentBox)).boundingBox()); I think this is only a partial change: RenderWidget::setWidgetGeometry still takes a LayoutRect and it shouldn't now that you are always passing an IntRect. Created attachment 137223 [details]
Patch
Comment on attachment 137223 [details]
Patch
OK.
Comment on attachment 137223 [details] Patch Clearing flags on attachment: 137223 Committed r114211: <http://trac.webkit.org/changeset/114211> All reviewed patches have been landed. Closing bug. |