Bug 83929

Summary: Fix pixelSnapping for CalendarPicker, MediaControl and ScrollbarPart
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric.carlson, eric, feature-media-reviews, jchaffraix, leviw, morrita, simon.fraser, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch none

Description Emil A Eklund 2012-04-13 12:17:15 PDT
Fix pixelSnapping for CalendarPicker, MediaControl and ScrollbarPart in preparation for turning on subpixel support.
Comment 1 Emil A Eklund 2012-04-13 12:25:51 PDT
Created attachment 137124 [details]
Patch
Comment 2 Julien Chaffraix 2012-04-13 15:26:19 PDT
Comment on attachment 137124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137124&action=review

> Source/WebCore/ChangeLog:22
> +        * rendering/RenderWidget.cpp:
> +        (WebCore::RenderWidget::updateWidgetGeometry):

Mhhh, left-over from another change? (RenderWidget is not marked in the bug description and should if you are also planning to change it)

> Source/WebCore/rendering/RenderWidget.cpp:183
> -    LayoutRect contentBox = contentBoxRect();
> +    IntRect contentBox = pixelSnappedIntRect(contentBoxRect());
>      if (!m_widget->transformsAffectFrameRect())
>          return setWidgetGeometry(absoluteContentBox());
>  
> -    LayoutRect absoluteContentBox(localToAbsoluteQuad(FloatQuad(contentBox)).boundingBox());
> +    IntRect absoluteContentBox(localToAbsoluteQuad(FloatQuad(contentBox)).boundingBox());

I think this is only a partial change: RenderWidget::setWidgetGeometry still takes a LayoutRect and it shouldn't now that you are always passing an IntRect.
Comment 3 Emil A Eklund 2012-04-14 18:45:51 PDT
Created attachment 137223 [details]
Patch
Comment 4 Eric Seidel (no email) 2012-04-14 20:15:19 PDT
Comment on attachment 137223 [details]
Patch

OK.
Comment 5 WebKit Review Bot 2012-04-14 20:51:40 PDT
Comment on attachment 137223 [details]
Patch

Clearing flags on attachment: 137223

Committed r114211: <http://trac.webkit.org/changeset/114211>
Comment 6 WebKit Review Bot 2012-04-14 20:51:47 PDT
All reviewed patches have been landed.  Closing bug.