Bug 83923

Summary: Track rem unit usage in StyleSheetInternal
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, kling, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-03 none

Description Antti Koivisto 2012-04-13 11:40:26 PDT 
Currently CSSParser sets usesRemUnits flag directly to Document. It should be set to the stylesheet instead so parser does not need to know about the document. This also avoids setting the flag unnecessarily when the stylesheet is not used.
Comment 1 Antti Koivisto 2012-04-13 11:43:33 PDT 
Created attachment 137116 [details]
patch
Comment 2 Andreas Kling 2012-04-13 11:55:30 PDT 
Comment on attachment 137116 [details]
patch

r=me
Comment 3 Antti Koivisto 2012-04-13 12:23:05 PDT 
Comment on attachment 137116 [details]
patch

This needs to deal with inline style too
Comment 4 Andreas Kling 2012-04-13 12:25:59 PDT 
(In reply to comment #3)
> (From update of attachment 137116 [details])
> This needs to deal with inline style too

Eep. Indeed. The easy way would be to simply have Document check the uses-rem-unit bit on its elementSheet() as well, but that would take us one step further away from killing elementSheet().
Comment 5 WebKit Review Bot 2012-04-13 13:35:42 PDT 
Comment on attachment 137116 [details]
patch

Attachment 137116 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12393979

New failing tests:
fast/css/rem-dynamic-scaling.html
Comment 6 WebKit Review Bot 2012-04-13 13:35:48 PDT 
Created attachment 137137 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 7 Antti Koivisto 2012-04-13 14:24:00 PDT 
http://trac.webkit.org/changeset/114168 (with a fix for the failing test)