Bug 83903

Summary: [BlackBerry] Increase padding for text element
Product: WebKit Reporter: Yongxin Dai <yodai>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Yongxin Dai 2012-04-13 10:43:33 PDT 
For in-region scroll mode, the selection handle can completely be invisible before scroll is triggered when the user is dragging handle over bottom / top of visible area.
Comment 1 Yongxin Dai 2012-04-13 11:23:42 PDT 
Created attachment 137110 [details]
Patch
Comment 2 Antonio Gomes 2012-04-13 11:52:59 PDT 
Comment on attachment 137110 [details]
Patch

can not we get even a manual test?
Comment 3 Yongxin Dai 2012-04-13 12:03:58 PDT 
(In reply to comment #2)
> (From update of attachment 137110 [details])
> can not we get even a manual test?
It was tested manually with email application. Composite a email with enough lines to trigger scroll. Drag handle over the bottom and top, which verified that problem is fixed by the patch.
Comment 4 Antonio Gomes 2012-04-13 12:16:30 PDT 
I'm talking about this: webkit/ManualTests/blackberry/
Comment 5 Mike Fenton 2012-04-13 14:08:51 PDT 
ChangeLog needs to be updated to include details from the Git commit message.  Also should remove the duplicate author line.
Comment 6 Antonio Gomes 2012-04-13 14:17:56 PDT 
Comment on attachment 137110 [details]
Patch

please fix mike's comments.
Comment 7 Yongxin Dai 2012-04-13 14:20:11 PDT 
(In reply to comment #6)
> (From update of attachment 137110 [details])
> please fix mike's comments.
Sure.
Comment 8 Yongxin Dai 2012-04-13 14:35:13 PDT 
Created attachment 137153 [details]
Patch
Comment 9 Yongxin Dai 2012-04-13 15:04:21 PDT 
Created attachment 137159 [details]
Patch
Comment 10 Mike Fenton 2012-04-16 05:23:54 PDT 
Comment on attachment 137159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137159&action=review

Fix the typo and it looks good to me.

> Source/WebKit/blackberry/ChangeLog:6
> +        Reviewed nternally by Mike Fenton.

Typo move this below your comment as well since it's not an official webkit review.
Comment 11 Yongxin Dai 2012-04-16 09:53:04 PDT 
Created attachment 137357 [details]
Patch
Comment 12 Yongxin Dai 2012-04-16 10:28:23 PDT 
Created attachment 137362 [details]
Patch
Comment 13 WebKit Review Bot 2012-04-16 11:28:00 PDT 
Comment on attachment 137362 [details]
Patch

Clearing flags on attachment: 137362

Committed r114282: <http://trac.webkit.org/changeset/114282>
Comment 14 WebKit Review Bot 2012-04-16 11:28:05 PDT 
All reviewed patches have been landed.  Closing bug.