Bug 83838

Summary: Prepare submitForm for seamless navigation
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, japhet, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
rniwa: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-01
none
Archive of layout-test-results from ec2-cq-02
none
Archive of layout-test-results from ec2-cq-01 none

Description Adam Barth 2012-04-12 18:01:28 PDT
Prepare submitForm for seamless navigation
Comment 1 Adam Barth 2012-04-12 18:04:01 PDT
Created attachment 137006 [details]
Patch
Comment 2 Ryosuke Niwa 2012-04-12 18:35:01 PDT
Comment on attachment 137006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137006&action=review

> Source/WebCore/loader/FrameLoader.cpp:317
> +    Frame* targetFrame = findFrameForNavigation(submission->target(), submission->state()->sourceDocument());
>      if (!targetFrame) {
>          if (!DOMWindow::allowPopUp(m_frame) && !ScriptController::processingUserGesture())
>              return;

Can we flip the if-else below so that we can declare targetFrame inside the if?
Comment 3 Adam Barth 2012-04-12 18:39:33 PDT
(In reply to comment #2)
> (From update of attachment 137006 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137006&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:317
> > +    Frame* targetFrame = findFrameForNavigation(submission->target(), submission->state()->sourceDocument());
> >      if (!targetFrame) {
> >          if (!DOMWindow::allowPopUp(m_frame) && !ScriptController::processingUserGesture())
> >              return;
> 
> Can we flip the if-else below so that we can declare targetFrame inside the if?

Sure.
Comment 4 Adam Barth 2012-04-12 18:45:52 PDT
Actually, we can't because targetFrame is used by the rest of the function (i.e., on both branches) for targetFrame->navigationScheduler()->scheduleFormSubmission(submission);
Comment 5 Ryosuke Niwa 2012-04-12 18:47:54 PDT
(In reply to comment #4)
> Actually, we can't because targetFrame is used by the rest of the function (i.e., on both branches) for targetFrame->navigationScheduler()->scheduleFormSubmission(submission);

Okay.
Comment 6 WebKit Review Bot 2012-04-12 21:07:39 PDT
Comment on attachment 137006 [details]
Patch

Attachment 137006 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12396541

New failing tests:
svg/text/font-size-below-point-five.svg
Comment 7 WebKit Review Bot 2012-04-12 21:07:45 PDT
Created attachment 137034 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 8 WebKit Review Bot 2012-04-12 23:04:47 PDT
Comment on attachment 137006 [details]
Patch

Rejecting attachment 137006 [details] from commit-queue.

New failing tests:
svg/transforms/text-with-mask-with-svg-transform.svg
svg/text/font-size-below-point-five.svg
Full output: http://queues.webkit.org/results/12391785
Comment 9 WebKit Review Bot 2012-04-12 23:04:53 PDT
Created attachment 137042 [details]
Archive of layout-test-results from ec2-cq-02

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 10 WebKit Review Bot 2012-04-13 00:45:31 PDT
Comment on attachment 137006 [details]
Patch

Rejecting attachment 137006 [details] from commit-queue.

New failing tests:
svg/text/font-size-below-point-five.svg
Full output: http://queues.webkit.org/results/12392806
Comment 11 WebKit Review Bot 2012-04-13 00:45:37 PDT
Created attachment 137053 [details]
Archive of layout-test-results from ec2-cq-01

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 12 Adam Barth 2012-04-13 00:46:00 PDT
Ok.  Maybe this is real.  :)
Comment 13 Ryosuke Niwa 2012-04-13 00:48:22 PDT
(In reply to comment #12)
> Ok.  Maybe this is real.  :)

No.... it's failing about 50% of the time on the bots.
Comment 14 Adam Barth 2012-04-13 00:49:16 PDT
In that case, I'm just going to land this manually, but we should mark it as flaky so it doesn't annoy other folks.
Comment 15 Ryosuke Niwa 2012-04-13 00:51:09 PDT
(In reply to comment #14)
> In that case, I'm just going to land this manually, but we should mark it as flaky so it doesn't annoy other folks.

Also see http://code.google.com/p/chromium/issues/detail?id=74710.
Comment 16 Adam Barth 2012-04-13 00:53:53 PDT
Committed r114093: <http://trac.webkit.org/changeset/114093>