Bug 83837

Summary: [chromium][refactoring] merge CCSingleThreadProxy::{commitIfNeeded,doComposite} into commitAndComposite()
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: WebKit Misc.Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, enne, jamesr, nduca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch jamesr: review+

Description Andrey Kosyakov 2012-04-12 17:51:08 PDT
Both call sites of commitIfNeeded() used to call doComposite() immediately in case commitIfNeeded() returned true. Having these two merged into a single method will keep things slightly more compact and will simplify instrumentation of the code -- we'd like to report them together to the instrumentation layer.
Comment 1 Andrey Kosyakov 2012-04-12 17:56:13 PDT
Created attachment 137003 [details]
Patch
Comment 2 James Robinson 2012-04-12 17:59:45 PDT
Comment on attachment 137003 [details]
Patch

Ooh, that is nice. R=me
Comment 3 Andrey Kosyakov 2012-04-12 18:08:38 PDT
Committed r114063: <http://trac.webkit.org/changeset/114063>
Comment 4 Nat Duca 2012-04-12 20:01:33 PDT
Coolies. Nice one.