Bug 83835

Summary: window.open should prepare for seamless navigation by using findFrameForNavigation
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-04-12 17:27:52 PDT
window.open should prepare for seamless navigation by using findFrameForNavigation
Attachments
Patch (4.61 KB, patch)
2012-04-12 17:30 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-04-12 17:30:48 PDT
Created attachment 137000 [details] Patch
Ryosuke Niwa
Comment 2 2012-04-12 17:37:48 PDT
Comment on attachment 137000 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137000&action=review > Source/WebCore/loader/FrameLoader.cpp:2947 > + // FIXME: Eventually all callers should supply the actual activeDocument > + // so we can call canNavigate with the right document. OMG! This might be the culprit of the bug I've been haunting for ages.
Adam Barth
Comment 3 2012-04-12 17:42:41 PDT
Comment on attachment 137000 [details] Patch Clearing flags on attachment: 137000 Committed r114057: <http://trac.webkit.org/changeset/114057>
Adam Barth
Comment 4 2012-04-12 17:42:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.