Summary: | [Chromium] Avoid unnecessary full tile updates for checkerboard tiles. | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Reveman <reveman> | ||||||||||||||
Component: | WebCore Misc. | Assignee: | David Reveman <reveman> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | cc-bugs, danakj, dglazkov, epenner, jamesr, nduca, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
David Reveman
2012-04-12 12:11:11 PDT
Are you thinking of storing something on the tile like 'isDirtyOnImpl' that says the tile has not been updated since becoming dirty? Created attachment 137005 [details]
Patch
Comment on attachment 137005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137005&action=review > Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp:352 > + if (!tile->isInUseOnImpl) > + return false; > + Also in tileOnlyNeedsPartialUpdate() right? Created attachment 137012 [details]
Patch
Comment on attachment 137012 [details]
Patch
+1
Comment on attachment 137012 [details] Patch Attachment 137012 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12396581 New failing tests: TiledLayerChromiumTest.partialUpdates Created attachment 137044 [details]
Archive of layout-test-results from ec2-cr-linux-01
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 137059 [details]
Patch
Comment on attachment 137059 [details]
Patch
R=me
Created attachment 137157 [details]
Patch
Update unit test to verify new behavior
Created attachment 137195 [details]
Patch
Comment on attachment 137195 [details]
Patch
You missed --no-review :)
Comment on attachment 137195 [details] Patch Clearing flags on attachment: 137195 Committed r114203: <http://trac.webkit.org/changeset/114203> All reviewed patches have been landed. Closing bug. |