Bug 83803

Summary: Make AccessibilityObject::size non-virtual and fix platform accessibility code's LayoutUnit usage
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, cfleizach, eae, eric, jchaffraix, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2012-04-12 12:06:08 PDT
AccessibilityObject has a virtual size() method, but all overloads do the same thing. Removing the virtual modifier and all overloaded copies of the function, adding a pixelSnappedSize method, and using it for platform code.
Attachments
Patch (11.65 KB, patch)
2012-04-12 12:11 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-04-12 12:11:37 PDT
Created attachment 136951 [details] Patch
Levi Weintraub
Comment 2 2012-04-12 13:08:51 PDT
Thanks Eric!
WebKit Review Bot
Comment 3 2012-04-12 13:57:04 PDT
Comment on attachment 136951 [details] Patch Clearing flags on attachment: 136951 Committed r114031: <http://trac.webkit.org/changeset/114031>
WebKit Review Bot
Comment 4 2012-04-12 13:57:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.