Bug 83772

Summary:

[BlackBerry] Set referrer for plugin load if needed.

Product:

WebKit

Reporter:

Charles Wei <charles.wei>

Component:

WebKit BlackBerry

Assignee:

Charles Wei <charles.wei>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

andersca, gustavo, manyoso, pnormand, rwlbuis, staikos, tonikitoo, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Bug Depends on:

Bug Blocks:

83360

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	tonikitoo: review-, pnormand: commit-queue-

Charles Wei

Reported 2012-04-12 05:19:04 PDT

Set referrer for resources requested by plugin.

Attachments
Patch (3.65 KB, patch) 2012-04-12 05:24 PDT, Charles Wei	no flags	Details Formatted Diff Diff
Patch (3.66 KB, patch) 2012-04-12 06:30 PDT, Charles Wei	no flags	Details Formatted Diff Diff
Patch (3.66 KB, patch) 2012-04-12 07:09 PDT, Charles Wei	tonikitoo: review- pnormand: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Charles Wei

Comment 1 2012-04-12 05:24:59 PDT

Created attachment 136883 [details] Patch

Rob Buis

Comment 2 2012-04-12 05:27:10 PDT

Comment on attachment 136883 [details] Patch Looks ideal for a helper method :)

Charles Wei

Comment 3 2012-04-12 05:46:05 PDT

(In reply to comment #2) > (From update of attachment 136883 [details]) > Looks ideal for a helper method :) Good suggestion. That makes less code.

Charles Wei

Comment 4 2012-04-12 06:30:42 PDT

Created attachment 136891 [details] Patch

Early Warning System Bot

Comment 5 2012-04-12 06:43:08 PDT

Comment on attachment 136891 [details] Patch Attachment 136891 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12390428

Philippe Normand

Comment 6 2012-04-12 06:46:15 PDT

Comment on attachment 136891 [details] Patch Attachment 136891 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12390426

Build Bot

Comment 7 2012-04-12 06:46:59 PDT

Comment on attachment 136891 [details] Patch Attachment 136891 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12387728

Charles Wei

Comment 8 2012-04-12 06:59:37 PDT

Comment on attachment 136891 [details] Patch typo in the patch, and revoke the review request.

Charles Wei

Comment 9 2012-04-12 07:09:20 PDT

Created attachment 136902 [details] Patch

Philippe Normand

Comment 10 2012-04-12 07:13:24 PDT

Comment on attachment 136902 [details] Patch Attachment 136902 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12395263

Early Warning System Bot

Comment 11 2012-04-12 07:14:10 PDT

Comment on attachment 136902 [details] Patch Attachment 136902 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12393383

Build Bot

Comment 12 2012-04-12 07:34:58 PDT

Comment on attachment 136902 [details] Patch Attachment 136902 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12389542

Antonio Gomes

Comment 13 2012-04-12 07:51:19 PDT

Comment on attachment 136902 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136902&action=review > Source/WebCore/ChangeLog:8 > + No new tests, initial upstream of BlackBerry porting. plePlease say what it fixes, and why others might not need this. > Source/WebCore/plugins/PluginView.cpp:127 > +static void setReferrerIfNeeded(FrameLoaderRequest request, const Frame* parentFrame) > +{ > +#if PLATFORM(BLACKBERRY) > + if (!SecurityPolicy::shouldHideReferrer(request.resourceRequest().url(), parentFrame->document()->baseURL())) > + request.resourceRequest().setHTTPReferrer(parentFrame->loader()->outgoingReferrer()); > +#endif > +} use param_unused in a #else block, please.

Note You need to log in before you can comment on or make changes to this bug.