Bug 83767

Summary: [BlackBerry] Revert the patch for 82764
Product: WebKit Reporter: Charles Wei <charles.wei>
Component: WebKit BlackBerryAssignee: Charles Wei <charles.wei>
Status: RESOLVED FIXED    
Severity: Normal CC: joenotcharles, rwlbuis, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 83360    
Attachments:
Description Flags
Patch
none
Patch none

Charles Wei
Reported 2012-04-12 03:28:28 PDT
The patch for bug 82764 is causing massive mis-function of BlackBerry porting and has been reverted internally. This patch reverts it also in upstream code to keep the upstream and internal repo in sync.
Attachments
Patch (5.32 KB, patch)
2012-04-12 03:35 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
Patch (5.24 KB, patch)
2012-04-12 06:51 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Charles Wei
Comment 1 2012-04-12 03:35:10 PDT
Created attachment 136869 [details] Patch
Rob Buis
Comment 2 2012-04-12 04:53:22 PDT
Comment on attachment 136869 [details] Patch When did this go in? Is there a PR for this?
Rob Buis
Comment 3 2012-04-12 04:57:44 PDT
Comment on attachment 136869 [details] Patch Ok, I see the original commit now. Can you explain more in the ChangeLog about the misfunction? And refer to the PR if it is there please.
Charles Wei
Comment 4 2012-04-12 05:43:09 PDT
(In reply to comment #3) > (From update of attachment 136869 [details]) > Ok, I see the original commit now. Can you explain more in the ChangeLog about the misfunction? And refer to the PR if it is there please. The malfunction is not caused by the patch in the webkit here, but in the platform code. This patch is reverted because of it's dependency on the platform part is reverted. I can change the commit log to include the internal PR, but it doesn't make much sense to detail the mis-function, I think, because it's not caused by the patch here :-)
Rob Buis
Comment 5 2012-04-12 06:01:27 PDT
Comment on attachment 136869 [details] Patch Looks good, but please include the PR before landing.
Charles Wei
Comment 6 2012-04-12 06:51:48 PDT
Created attachment 136896 [details] Patch
Charles Wei
Comment 7 2012-04-12 06:54:03 PDT
(In reply to comment #5) > (From update of attachment 136869 [details]) > Looks good, but please include the PR before landing. Sorry , there's no internal PR that reverted the patch internally. I did included the internal SHA for reference.
Antonio Gomes
Comment 8 2012-04-12 07:53:39 PDT
you can use the sheriffbot to revert patches
WebKit Review Bot
Comment 9 2012-04-12 07:55:47 PDT
Comment on attachment 136896 [details] Patch Clearing flags on attachment: 136896 Committed r113976: <http://trac.webkit.org/changeset/113976>
WebKit Review Bot
Comment 10 2012-04-12 07:55:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.