[Chromium] Add WebKit API to access <datalist> options

• Component: Forms
• Status: RESOLVED FIXED

[Keishi Hattori]

Introduce WebDataListElement and expose HTMLDataListElement to chromium.

[Keishi Hattori]

Created attachment 136877 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Keishi Hattori]

Created attachment 136882 [details]
Patch

[Kent Tamura]

Comment on attachment 136882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136882&action=review

r- because of unrelated indentation fix.

> Source/WebKit/chromium/ChangeLog:14
> +        * public/WebInputElement.h: Fix indentation.

Please do not fix indentation in this patch.

> Source/WebKit/chromium/public/WebInputElement.h:90
> +    WEBKIT_EXPORT WebDataListElement dataList() const;
> +

We won't need WebDataListElement if we introduce just "WebNodeCollection dataListOptions()" to WebInputElement.  What do you think?

[Keishi Hattori]

Comment on attachment 136882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136882&action=review

>> Source/WebKit/chromium/public/WebInputElement.h:90
>> +
> 
> We won't need WebDataListElement if we introduce just "WebNodeCollection dataListOptions()" to WebInputElement.  What do you think?

Do we add HTMLInputElement::dataListOptions()? or are we allowed to implement it in WebInputElement.cpp?

[Keishi Hattori]

Created attachment 136898 [details]
Reverted indentation fix

[WebKit Review Bot]

Comment on attachment 136898 [details]
Reverted indentation fix

Attachment 136898 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12392425

[Kent Tamura]

(In reply to comment #5)
> Do we add HTMLInputElement::dataListOptions()? or are we allowed to implement it in WebInputElement.cpp?

The latter is ok.

[Kent Tamura]

Comment on attachment 136898 [details]
Reverted indentation fix

r- because of a build failure

[Keishi Hattori]

Created attachment 137055 [details]
Used WebInputElement::dataListOptions

[WebKit Review Bot]

Attachment 137055 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1
Source/WebKit/chromium/public/WebInputElement.h:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kent Tamura]

Comment on attachment 137055 [details]
Used WebInputElement::dataListOptions

Looks reasonable.

[WebKit Review Bot]

Comment on attachment 137055 [details]
Used WebInputElement::dataListOptions

Clearing flags on attachment: 137055

Committed r114108: <http://trac.webkit.org/changeset/114108>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.