Bug 83725

Summary:

ThreadingWin: Mutex::unlock() can be "over-unlocked".

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

WebCore Misc.

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

levin+threading, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Jer Noble

Reported 2012-04-11 15:28:29 PDT

Unlocking a Mutex more times than it's m_recursionCount will result in the m_recursionCount wrapping around to MAX_INT. There should be at least an ASSERT(m_recursionCount) in Mutex::unlock(), if not an explicit: "if (m_recursionCount) --resursionCount;"

Attachments
Patch (1.56 KB, patch) 2012-04-12 11:59 PDT, Jer Noble	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2012-04-12 11:59:22 PDT

Created attachment 136949 [details] Patch

WebKit Review Bot

Comment 2 2012-04-12 13:35:36 PDT

Comment on attachment 136949 [details] Patch Clearing flags on attachment: 136949 Committed r114028: <http://trac.webkit.org/changeset/114028>

WebKit Review Bot

Comment 3 2012-04-12 13:35:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.