Bug 83718

Summary: Web Inspector: show wall time frame duration on the vertical overview
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, nduca, pfeldman, pmuellr, rik, timothy, yurys, yusufalaaothman001
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
screenshot (regular frames, outliers clearly seen)
none
screenshot (irregular -- scrolling techcrunch back and forth)
none
Patch pfeldman: review+

Description Andrey Kosyakov 2012-04-11 14:14:56 PDT
We'd like to spot frames that took long to render even in cases where CPU time usage by nested events was small, so add a contour for overall frame length to frame bars in the vertical overview.
This also requires better scaling logic, so that should we have any irregularly-long frames (i.e. in absence of requestAnimationFrame calls), these do not dwarf the rest of the frames -- so we now scale to no more than 3 * median_frame_length, which causes badly outlying frames to rocket into the sky (right in time for April, 12th).
Comment 1 Andrey Kosyakov 2012-04-11 14:20:21 PDT
Created attachment 136753 [details]
screenshot (regular frames, outliers clearly seen)
Comment 2 Andrey Kosyakov 2012-04-11 14:20:58 PDT
Created attachment 136754 [details]
screenshot (irregular -- scrolling techcrunch back and forth)
Comment 3 Andrey Kosyakov 2012-04-11 14:30:57 PDT
Created attachment 136756 [details]
Patch
Comment 4 Andrey Kosyakov 2012-04-12 09:29:54 PDT
Committed r113994: <http://trac.webkit.org/changeset/113994>