Bug 83687

Summary:

[EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation

Product:

WebKit

Reporter:

Mikhail Pozdnyakov <mikhail.pozdnyakov>

Component:

WebKit EFL

Assignee:

Mikhail Pozdnyakov <mikhail.pozdnyakov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation	none
EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation	tonikitoo: review+, webkit.review.bot: commit-queue-
to be landed.	none

Mikhail Pozdnyakov

Reported 2012-04-11 03:59:53 PDT

EFL's LayoutTestController needs setJavaScriptCanAccessClipboard implementation, so that it is possible to unskip editing/execCommand/clipboard-access.html

Attachments
EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation (6.89 KB, patch) 2012-04-12 01:32 PDT, Mikhail Pozdnyakov	no flags	Details Formatted Diff Diff
EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation (6.90 KB, patch) 2012-04-12 03:59 PDT, Mikhail Pozdnyakov	tonikitoo: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
to be landed. (6.86 KB, patch) 2012-05-06 11:27 PDT, Mikhail Pozdnyakov	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mikhail Pozdnyakov

Comment 1 2012-04-12 01:32:19 PDT

Created attachment 136850 [details] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation Keeping ewk_view_setting family, as the approach proposed in https://bugs.webkit.org/show_bug.cgi?id=83007 is not agreed yet.

Gyuyoung Kim

Comment 2 2012-04-12 03:06:39 PDT

Comment on attachment 136850 [details] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation Attachment 136850 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12391343

Mikhail Pozdnyakov

Comment 3 2012-04-12 03:59:34 PDT

Created attachment 136874 [details] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation

Gyuyoung Kim

Comment 4 2012-04-12 06:23:05 PDT

Comment on attachment 136874 [details] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation Other ports(e.g. blackberry, mac, gtk and qt) support this setting APis. Looks fine except for description in ChangeLog.

Raphael Kubo da Costa (:rakuco)

Comment 5 2012-04-12 08:19:27 PDT

Comment on attachment 136874 [details] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation Looks fine, thanks.

WebKit Review Bot

Comment 6 2012-05-03 10:55:14 PDT

Comment on attachment 136874 [details] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation Rejecting attachment 136874 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: jects to file Source/WebKit/efl/ewk/ewk_view.cpp.rej patching file Source/WebKit/efl/ewk/ewk_view.h Hunk #1 succeeded at 1555 (offset 53 lines). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp Hunk #1 succeeded at 332 with fuzz 1 (offset 12 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12613326

Mikhail Pozdnyakov

Comment 7 2012-05-06 11:27:59 PDT

Created attachment 140430 [details] to be landed.

Raphael Kubo da Costa (:rakuco)

Comment 8 2012-05-06 11:54:37 PDT

Comment on attachment 140430 [details] to be landed. cq+'ing. I strongly recommend using webkit-patch to upload your patches instead of doing so manually; besides it making the whole process much quicker, it also marks previous patches as obsolete, which you sometimes forget to do.

WebKit Review Bot

Comment 9 2012-05-06 16:27:35 PDT

Comment on attachment 140430 [details] to be landed. Clearing flags on attachment: 140430 Committed r116250: <http://trac.webkit.org/changeset/116250>

WebKit Review Bot

Comment 10 2012-05-06 16:27:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.