| Summary: | Calendar Picker: remove unnecessary code from calendarPicker.{css,js} | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
| Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | haraken, morrita | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 53961 | ||||||
| Attachments: |
|
||||||
Created attachment 136651 [details]
Patch
Comment on attachment 136651 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136651&action=review > Source/WebCore/ChangeLog:12 > + - leading adn trailing whitespace (.js and .css) Nit: *and* > Source/WebCore/make-file-arrays.py:59 > + leading_space = re.compile(r"^ ", re.MULTILINE) This regular expression is assuming that repeating_space.sub() runs before leading_space.sub(). To remove the assumption, r"^[ \t]+" might be better. > Source/WebCore/make-file-arrays.py:60 > + trailing_space = re.compile(r" $", re.MULTILINE) Ditto. r"[ \t]+$" might be better. > Source/WebCore/make-file-arrays.py:75 > + print content Remove this Committed r114090: <http://trac.webkit.org/changeset/114090> (In reply to comment #2) > > Source/WebCore/ChangeLog:12 > > + - leading adn trailing whitespace (.js and .css) > > Nit: *and* Fixed. > > Source/WebCore/make-file-arrays.py:59 > > + leading_space = re.compile(r"^ ", re.MULTILINE) > > This regular expression is assuming that repeating_space.sub() runs before leading_space.sub(). To remove the assumption, r"^[ \t]+" might be better. Fixed. > > Source/WebCore/make-file-arrays.py:60 > > + trailing_space = re.compile(r" $", re.MULTILINE) > > Ditto. r"[ \t]+$" might be better. Fixed. > > Source/WebCore/make-file-arrays.py:75 > > + print content > > Remove this Removed. |
Calendar Picker: remove unnecessary code from calendarPicker.{css,js}