Bug 83658

Summary: [chromium] Add OVERRIDE annotations for cc layer types
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, dbates, eric.carlson, feature-media-reviews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 83645    
Attachments:
Description Flags
Patch dbates: review+

James Robinson
Reported 2012-04-10 19:46:00 PDT
[chromium] Add OVERRIDE annotations for cc layer types
Attachments
Patch (30.27 KB, patch)
2012-04-10 19:48 PDT, James Robinson 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-04-10 19:48:03 PDT
Created attachment 136611 [details] Patch
Daniel Bates
Comment 2 2012-04-10 21:24:44 PDT
Comment on attachment 136611 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136611&action=review > Source/WebKit/chromium/ChangeLog:14 > + * src/WebLayerImpl.cpp: > + * src/WebLayerImpl.h: For your consideration I suggest adding a remark to the right of these files to explain that you are removing the function WebLayerImpl::paintContents() instead of adding an override annotation to it.
James Robinson
Comment 3 2012-04-11 13:20:08 PDT
Committed r113902: <http://trac.webkit.org/changeset/113902>
Note You need to log in before you can comment on or make changes to this bug.