Bug 83655

Summary: Delete CanvasPixelArray, ByteArray, JSByteArray and JSC code once unreferenced
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: JavaScriptCoreAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, fpizlo, haraken, japhet, noam, ojan, oliver, rakuco, vestbo, webkit.review.bot, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 73011    
Bug Blocks:    
Attachments:
Description Flags
Patch for EWS bots
none
Patch none

Kenneth Russell
Reported 2012-04-10 19:28:06 PDT
Once https://bugs.webkit.org/show_bug.cgi?id=73011 is fixed, ByteArray, JSByteArray and a bunch of JSC code dealing with CanvasPixelArray will be unreferenced and can be deleted. This is being separated out from the cutover in order to keep the sizes of the patches manageable.
Attachments
Patch for EWS bots (122.51 KB, patch)
2012-04-25 10:47 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (122.54 KB, patch)
2012-04-25 13:26 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2012-04-25 10:47:38 PDT
Created attachment 138842 [details] Patch for EWS bots
Early Warning System Bot
Comment 2 2012-04-25 10:57:48 PDT
Comment on attachment 138842 [details] Patch for EWS bots Attachment 138842 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12517642
Early Warning System Bot
Comment 3 2012-04-25 11:46:27 PDT
Comment on attachment 138842 [details] Patch for EWS bots Attachment 138842 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12521598
Kenneth Russell
Comment 4 2012-04-25 13:26:10 PDT
Created attachment 138867 [details] Patch
Kenneth Russell
Comment 5 2012-04-25 13:26:52 PDT
Here's the patch. I'm quite pleased with the amount of code that was able to be deleted. Please review.
Noam Rosenthal
Comment 6 2012-04-25 14:02:23 PDT
Thanks for not leaving the qt ews red!
Kenneth Russell
Comment 7 2012-04-25 14:23:13 PDT
(In reply to comment #6) > Thanks for not leaving the qt ews red! Of course of course!
WebKit Review Bot
Comment 8 2012-04-25 15:12:10 PDT
Comment on attachment 138867 [details] Patch Clearing flags on attachment: 138867 Committed r115248: <http://trac.webkit.org/changeset/115248>
WebKit Review Bot
Comment 9 2012-04-25 15:12:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.