Bug 83604 – Clean up multiple RenderedPosition::absoluteRect definitions and correct LayoutUnit usage

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Levi Weintraub]

There are currently 3 definitions of RenderedPosition::absoluteRect where only one is needed. It also currently returns a LayoutRect despite being in absolute coordinates, which should be integers.

[Levi Weintraub]

Created attachment 136508 [details]
Patch

[Julien Chaffraix]

Comment on attachment 136508 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136508&action=review

> Source/WebCore/editing/RenderedPosition.cpp:232
> +    IntRect localRect = pixelSnappedIntRect(m_renderer->localCaretRect(m_inlineBox, m_offset, extraWidthToEndOfLine));

For people watching at home, the pixelSnappedIntRect confused me a lot and I pinged leviw@ about that. Currently we want to snap our rectangles before calling localToAbsoluteQuad to be consistent across all the painting code.

We may lose some precision by doing so (if we have a transform that is not pixel aligned for example), but coherency is better for now. We may relax this requirement later.

[Levi Weintraub]

Comment on attachment 136508 [details]
Patch

Thanks Julien!

[WebKit Review Bot]

Comment on attachment 136508 [details]
Patch

Clearing flags on attachment: 136508

Committed r113792: <http://trac.webkit.org/changeset/113792>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.