Bug 83587 – [Qt] Fix issues when using the WebView as ShaderEffectSource

• Component: New Bugs
• Status: RESOLVED FIXED

[Jocelyn Turcotte]

[Qt] Fix issues when using the WebView as ShaderEffectSource

[Jocelyn Turcotte]

Created attachment 136480 [details]
Patch

[Noam Rosenthal]

Comment on attachment 136480 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136480&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:126
> +    virtual void beginPainting(bool mirrored = false) { }

Boolean trap. Let's make it an enum.

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:500
> +static inline TransformationMatrix createProjectionMatrix(const IntSize& size, bool mirrored)

While we're at it, let's make this an enum (probably the same enum).

[Jocelyn Turcotte]

Created attachment 136495 [details]
Patch

Using PaintingFlag instead of a mirrored bool.
It felt a bit stretched to use the generic flag in the createProjectionMatrix static method so I leaved it as before but used const bools for the mirrored parameter in callers.

[Noam Rosenthal]

Comment on attachment 136495 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136495&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:107
> +    enum PaintingFlag {
> +        PaintingMirrored = 1 << 0,

PaintFlag(s)

[Jocelyn Turcotte]

Committed r113859: <http://trac.webkit.org/changeset/113859>