Summary: | Web Inspector: ASSERT attempting to unbind null contentDocument | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2012-04-09 19:11:46 PDT
Created attachment 136374 [details]
[PATCH] Proposed Fix
I was unable to reproduce this so I couldn't create a test case. =(
In the fix we still call didRemoveDocument because that handles null
and does other work.
Comment on attachment 136374 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=136374&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:338 > + m_domListener->didRemoveDocument(contentDocument); Is it safe to pass a null contenDocument to didRemoveDocument? (In reply to comment #3) > (From update of attachment 136374 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=136374&action=review > > > Source/WebCore/inspector/InspectorDOMAgent.cpp:338 > > + m_domListener->didRemoveDocument(contentDocument); > > Is it safe to pass a null contenDocument to didRemoveDocument? Yep, and I think its preferred since that does other work we might want: void InspectorCSSAgent::didRemoveDocument(Document* document) { if (document) m_documentToInspectorStyleSheet.remove(document); clearPseudoState(false); } Comment on attachment 136374 [details] [PATCH] Proposed Fix Clearing flags on attachment: 136374 Committed r113675: <http://trac.webkit.org/changeset/113675> All reviewed patches have been landed. Closing bug. |