Bug 83507

Summary: Clean up LayoutUnit usage in DOMNodeHighlighter
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric, jchaffraix, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2012-04-09 14:30:27 PDT
Bringing DOMNodeHighlighter in line with the subpixellayout branch.
Attachments
Patch (5.50 KB, patch)
2012-04-09 14:39 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-04-09 14:39:56 PDT
Created attachment 136309 [details] Patch
Eric Seidel (no email)
Comment 2 2012-04-09 14:41:48 PDT
Comment on attachment 136309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136309&action=review > Source/WebCore/ChangeLog:11 > + Ensuring DOMNodeHighlighter uses pixel snapping that matches that done in the RenderTree. Changes include: > + - Reverting drawSubstring to use an IntPoint with pixel snapped values instead of a LayoutPoint. > + - Reverting borderBox to an IntRect since it's in absolute coordinates. See https://trac.webkit.org/wiki/LayoutUnit. > + - Frames are still laid out with integers. Cleaning up mainFrameOffset to reflect that. Nicely stated!
Levi Weintraub
Comment 3 2012-04-09 14:43:48 PDT
Comment on attachment 136309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136309&action=review >> Source/WebCore/ChangeLog:11 >> + - Frames are still laid out with integers. Cleaning up mainFrameOffset to reflect that. > > Nicely stated! Thanks!
WebKit Review Bot
Comment 4 2012-04-09 19:32:36 PDT
Comment on attachment 136309 [details] Patch Clearing flags on attachment: 136309 Committed r113663: <http://trac.webkit.org/changeset/113663>
WebKit Review Bot
Comment 5 2012-04-09 19:32:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.