Bug 83505 – Remove setTimeout from media/video-seek-past-end-paused.html and fix other minor issues

• Component: New Bugs
• Status: RESOLVED FIXED

[Victoria Kirst]

Remove setTimeout from media/video-seek-past-end-paused.html and fix other minor issues

[Victoria Kirst]

Created attachment 136302 [details]
Patch

[Eric Carlson]

Comment on attachment 136302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136302&action=review

> LayoutTests/media/video-seek-past-end-paused.html:14
> +                run("video.load()");

Nit: load() is unnecessary, setting 'src' implicitly schedules a load.

[Victoria Kirst]

Created attachment 136308 [details]
Patch

[Victoria Kirst]

Comment on attachment 136308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136302&action=review

>> LayoutTests/media/video-seek-past-end-paused.html:14
>> +                run("video.load()");
> 
> Nit: load() is unnecessary, setting 'src' implicitly schedules a load.

Thanks! Removed, and moved the line to set src waitForEvent('canplaythrough').

[WebKit Review Bot]

Comment on attachment 136308 [details]
Patch

Rejecting attachment 136308 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12374325

[Victoria Kirst]

Committed r114005: <http://trac.webkit.org/changeset/114005>