Bug 83473

Summary: [BlackBerry] Implement Web Inspector methods in LayoutTestController
Product: WebKit Reporter: Konrad Piascik <kpiascik>
Component: WebKit BlackBerryAssignee: Konrad Piascik <kpiascik>
Status: RESOLVED INVALID    
Severity: Normal CC: andersca, dbates, efidler, eric, rwlbuis, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Konrad Piascik
Reported 2012-04-09 08:33:09 PDT
[BlackBerry] Implement Web Inspector methods in LayoutTestController
Attachments
Patch (2.29 KB, patch)
2012-04-09 09:42 PDT, Konrad Piascik 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konrad Piascik
Comment 1 2012-04-09 09:42:17 PDT
Created attachment 136242 [details] Patch
Daniel Bates
Comment 2 2012-04-09 21:06:27 PDT
Comment on attachment 136242 [details] Patch This patch looks straightforward to me. r=me.
Daniel Bates
Comment 3 2012-04-09 21:09:49 PDT
Comment on attachment 136242 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136242&action=review > Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:507 > + WTF::String scriptStr = jsStringRefToWebCoreString(script); Nit: I don't see the value of abbreviating the word "string" here. I suggest naming this variable scriptString.
Eric Seidel (no email)
Comment 4 2013-01-04 00:51:01 PST
Attachment 136242 [details] was posted by a committer and has review+, assigning to Konrad Piascik for commit.
Konrad Piascik
Comment 5 2013-01-04 10:18:42 PST
Comment on attachment 136242 [details] Patch This change doesn't do anything and is simply a setup for future work to get inspector tests to work. I'll upload another patch which will have this work with other changes later rather than splitting it into two separate commits.
Eric Seidel (no email)
Comment 6 2013-03-01 10:36:57 PST
Comment on attachment 136242 [details] Patch Cleared Daniel Bates's review+ from obsolete attachment 136242 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Note You need to log in before you can comment on or make changes to this bug.