Bug 83457

Summary: [BlackBerry] Parsed Cookie's m_isMaxAgeSet is not needed.
Product: WebKit Reporter: Jason Liu <jasonliuwebkit>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: joenotcharles, kpiascik, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Jason Liu 2012-04-09 00:30:14 PDT 
m_isMaxAgeSet is not needed. And m_isMaxAgeSet is wrong when the cookie is from database.
Comment 1 Jason Liu 2012-04-09 00:38:08 PDT 
Created attachment 136193 [details]
Patch
Comment 2 Konrad Piascik 2012-04-09 06:34:29 PDT 
Looks good to me.
Comment 3 Rob Buis 2012-04-09 06:53:57 PDT 
Comment on attachment 136193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136193&action=review

Looks good, but please fix the ChangeLog before landing.

> Source/WebCore/ChangeLog:7
> +

Please add an explanation, i.e. how and why you can use m_expiry instead.
Comment 4 Jason Liu 2012-04-09 18:27:31 PDT 
(In reply to comment #3)
> (From update of attachment 136193 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=136193&action=review
> 
> Looks good, but please fix the ChangeLog before landing.
> 
> > Source/WebCore/ChangeLog:7
> > +
> 
> Please add an explanation, i.e. how and why you can use m_expiry instead.

Thank you. I will do that asap.
Comment 5 Jason Liu 2012-04-09 18:50:08 PDT 
Created attachment 136367 [details]
Patch
Comment 6 Jason Liu 2012-04-09 18:55:40 PDT 
Created attachment 136371 [details]
Patch
Comment 7 Leo Yang 2012-04-09 19:13:23 PDT 
Comment on attachment 136371 [details]
Patch

Sending to the cq ...
Comment 8 WebKit Review Bot 2012-04-09 21:28:11 PDT 
Comment on attachment 136371 [details]
Patch

Clearing flags on attachment: 136371

Committed r113674: <http://trac.webkit.org/changeset/113674>
Comment 9 WebKit Review Bot 2012-04-09 21:28:16 PDT 
All reviewed patches have been landed.  Closing bug.