Bug 83457 - [BlackBerry] Parsed Cookie's m_isMaxAgeSet is not needed.
Summary: [BlackBerry] Parsed Cookie's m_isMaxAgeSet is not needed.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-09 00:30 PDT by Jason Liu
Modified: 2012-04-09 21:28 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.34 KB, patch)
2012-04-09 00:38 PDT, Jason Liu
no flags Details | Formatted Diff | Diff
Patch (3.67 KB, patch)
2012-04-09 18:50 PDT, Jason Liu
no flags Details | Formatted Diff | Diff
Patch (3.65 KB, patch)
2012-04-09 18:55 PDT, Jason Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Liu 2012-04-09 00:30:14 PDT
m_isMaxAgeSet is not needed. And m_isMaxAgeSet is wrong when the cookie is from database.
Comment 1 Jason Liu 2012-04-09 00:38:08 PDT
Created attachment 136193 [details]
Patch
Comment 2 Konrad Piascik 2012-04-09 06:34:29 PDT
Looks good to me.
Comment 3 Rob Buis 2012-04-09 06:53:57 PDT
Comment on attachment 136193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136193&action=review

Looks good, but please fix the ChangeLog before landing.

> Source/WebCore/ChangeLog:7
> +

Please add an explanation, i.e. how and why you can use m_expiry instead.
Comment 4 Jason Liu 2012-04-09 18:27:31 PDT
(In reply to comment #3)
> (From update of attachment 136193 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=136193&action=review
> 
> Looks good, but please fix the ChangeLog before landing.
> 
> > Source/WebCore/ChangeLog:7
> > +
> 
> Please add an explanation, i.e. how and why you can use m_expiry instead.

Thank you. I will do that asap.
Comment 5 Jason Liu 2012-04-09 18:50:08 PDT
Created attachment 136367 [details]
Patch
Comment 6 Jason Liu 2012-04-09 18:55:40 PDT
Created attachment 136371 [details]
Patch
Comment 7 Leo Yang 2012-04-09 19:13:23 PDT
Comment on attachment 136371 [details]
Patch

Sending to the cq ...
Comment 8 WebKit Review Bot 2012-04-09 21:28:11 PDT
Comment on attachment 136371 [details]
Patch

Clearing flags on attachment: 136371

Committed r113674: <http://trac.webkit.org/changeset/113674>
Comment 9 WebKit Review Bot 2012-04-09 21:28:16 PDT
All reviewed patches have been landed.  Closing bug.