Bug 83455

Summary:

DFG should not load the property storage if it is inline.

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	none
the patch	barraclough: review+

Description Filip Pizlo 2012-04-08 23:19:54 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2012-04-08 23:26:01 PDT

Created attachment 136187 [details]
the patch

Comment 2 WebKit Review Bot 2012-04-08 23:29:12 PDT

Attachment 136187 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1888:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Filip Pizlo 2012-04-08 23:33:37 PDT

Created attachment 136188 [details]
the patch

Fixed style

Comment 4 Filip Pizlo 2012-04-09 00:48:34 PDT

Landed in http://trac.webkit.org/changeset/113557